-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beatmap/BeatmapPlayback refactor #515
Conversation
In 3ddcfa3, I re-implemented the stops so that they work like this now:
This makes using stops and |
Also, I added On the subject of testing scroll speed changes:
|
Fixed a regression in #515 (objects not visible for certain cases during practice mode)
Originally planned to split #445 into two PRs, but realized that adding supports for scroll speeds is quite small yet necessary for the refactoring.
LineGraph
, which is future-compatible with KSON.m_objectStates
)BeatmapPlayback::Update
where passed objects are checked.There's one side-effect to this PR: