-
-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last PR before merge to main #57
Conversation
Yes yes agreed :D I'll run a test, in Vietnamese and in English to make sure that it can successfully use the fairseq and XTTS model And then double check the readme And then merge 👌 |
I will push a new PR today, there are still things to change. about fairseq model we must still integrate it. |
Yes yes yes, I was also thinking about setting a preferred tts model order so each language defaults to the best sounding compatible model. Right now order being: Best:XTTS----> Next Best:fairseq |
I have to recheck the language_mapping again, wrong ISO codes. |
the facebook/mm-tts is about 1TB :-| . so not good to import it all locally ... |
lol yeah well just have them download the fairseq models on the fly, It's only around 135 mb for each anyway |
Oh yeah, I think the iso code values are fine in the You probs already 10 steps ahead of me on this though XD |
oh yeah and probably good to have the faiseq models generate:
|
I'll run some fairseq speed testing on my end with and without voice cloning to double check 👌 |
we can do it with tts --out_path output/path/speech.wav --model_name "//<model_name>" --source_wav <path/to/speaker/wav> --target_wav <path/to/reference/wav> |
Ah so voice conversion 👌 looks like that should work cause I was having trouble on my end with trying to pass it though in one command with a fairseq model and voice cloning in one command Good to know you found a way then 👍 |
I'll see about finding a more automated way of generating a bunch more of the test ebook files |
?🙏 |
Might have some free time to try a go at implementing the fairseq model for the finaly 2.0 update in a bit, Unless your already working on it lol. |
I'm already working on it since 2 days now. preparing the repo for the 1142 languages... should be ok for tonight. |
kk 👍oooo vits2? 👀 👀 👀 oh also
|
yes, the readme should be rebased. like adding the new options (--ebook-dir for ex) and behavior (no need to add True to the option, like --headless etc..), the video screenshot too :) |
👍👍 I'll get on that 🫡 |
this last PR makes me think it should be ok for the merge of your main branch.
we reached 1k stars, so it's time to bring them to the new version...
it will also bring certainly more contributors..