Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rust compile on dockerfile #1612

Merged
merged 6 commits into from
Mar 25, 2021
Merged

Conversation

GuillaumeDSM
Copy link
Member

Based on #1611
thanks to @gabriel-milan

Copy link
Member

@Herklos Herklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! 🎉

@Herklos Herklos enabled auto-merge (rebase) March 23, 2021 19:25
@Herklos
Copy link
Member

Herklos commented Mar 23, 2021

Still running after ~3h 😄

@gabriel-milan
Copy link
Contributor

Yeah same thing that happened to mine.

Error: buildx call failed with: error: failed to solve: rpc error: code = Unknown desc = docker exporter does not currently support exporting manifest lists

Idk why this is happening as this is the official Docker GH action.

@gabriel-milan
Copy link
Contributor

Update: I was able to build it on my RPi as it is on the disable_rust_compile_on_dockerfile branch. It took a while though (~2.5 hours). I'll try to come up with something for this GH action that's failing.

@GuillaumeDSM
Copy link
Member Author

Update: I was able to build it on my RPi as it is on the disable_rust_compile_on_dockerfile branch. It took a while though (~2.5 hours). I'll try to come up with something for this GH action that's failing.

Great news !
Thanks for this @gabriel-milan

@gabriel-milan
Copy link
Contributor

gabriel-milan commented Mar 24, 2021

Well, it seems to be OK (https://github.com/gabriel-milan/OctoBot/pull/3/checks?check_run_id=2183699151).

Apparently, when you use --load (or load: true on the YAML), you're forcing the builder driver to docker (see docs) and for now it still doesn't support multi-platform builds (as previously mentioned on docker/buildx#59). By removing it, it builds just fine.

I'm not quite sure that, by doing this, the caching mechanism will work, but I think it will. Besides that, this GH action looks like an alternative if we can't dig deeper on this issue.

Finally, I think that the only thing that still needs changing on the Dockerfile is on lines 150 and 169 (in my current version) by adding linux/arm/v7 to the platform list.

GitHub
Thank you for sending your pull request. But first, have you included unit tests, and is your code PEP8 conformant? More details Summary Explain in one sentence the goal of this PR Solve the issue:...

@GuillaumeDSM GuillaumeDSM force-pushed the disable_rust_compile_on_dockerfile branch 2 times, most recently from 4e56d75 to 1aef8c5 Compare March 24, 2021 19:07
@GuillaumeDSM GuillaumeDSM force-pushed the disable_rust_compile_on_dockerfile branch from 98fa9e4 to 4c531c2 Compare March 25, 2021 12:05
@Herklos Herklos merged commit 7e0d27f into dev Mar 25, 2021
@Herklos Herklos deleted the disable_rust_compile_on_dockerfile branch March 25, 2021 22:45
@gabriel-milan
Copy link
Contributor

It's me again, guys. I've checked and I think that this

Finally, I think that the only thing that still needs changing on the Dockerfile is on lines 150 and 169 (in my current version) by adding linux/arm/v7 to the platform list.

is still missing. Would you like me to commit it somewhere or you guys can do it?

@GuillaumeDSM
Copy link
Member Author

It's me again, guys. I've checked and I think that this

Finally, I think that the only thing that still needs changing on the Dockerfile is on lines 150 and 169 (in my current version) by adding linux/arm/v7 to the platform list.

is still missing. Would you like me to commit it somewhere or you guys can do it?

I created this PR, is it what you where thinking to add ? #1616

@gabriel-milan
Copy link
Contributor

It's me again, guys. I've checked and I think that this

Finally, I think that the only thing that still needs changing on the Dockerfile is on lines 150 and 169 (in my current version) by adding linux/arm/v7 to the platform list.

is still missing. Would you like me to commit it somewhere or you guys can do it?

I created this PR, is it what you where thinking to add ? #1616

Yeah, that's exactly it. Sorry I've missed that, thank you again!

@GuillaumeDSM
Copy link
Member Author

Thank you for quickly noticing the issue !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants