-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable rust compile on dockerfile #1612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! 🎉
Still running after ~3h 😄 |
Yeah same thing that happened to mine.
Idk why this is happening as this is the official Docker GH action. |
Update: I was able to build it on my RPi as it is on the disable_rust_compile_on_dockerfile branch. It took a while though (~2.5 hours). I'll try to come up with something for this GH action that's failing. |
Great news ! |
Well, it seems to be OK (https://github.com/gabriel-milan/OctoBot/pull/3/checks?check_run_id=2183699151). Apparently, when you use I'm not quite sure that, by doing this, the caching mechanism will work, but I think it will. Besides that, this GH action looks like an alternative if we can't dig deeper on this issue. Finally, I think that the only thing that still needs changing on the Dockerfile is on lines 150 and 169 (in my current version) by adding
|
4e56d75
to
1aef8c5
Compare
98fa9e4
to
4c531c2
Compare
It's me again, guys. I've checked and I think that this
is still missing. Would you like me to commit it somewhere or you guys can do it? |
I created this PR, is it what you where thinking to add ? #1616 |
Yeah, that's exactly it. Sorry I've missed that, thank you again! |
Thank you for quickly noticing the issue ! |
Based on #1611
thanks to @gabriel-milan