Small changes from the OpenGL branch #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasky
force-pushed
the
rdpq_merge
branch
2 times, most recently
from
0f336e1 to
dd6d137
Compare
anacierdem
requested changes
Dec 18, 2022
rasky
force-pushed
the
rdpq_merge
branch
2 times, most recently
from
74ac458 to
91f6aac
Compare
This allows to define in the future multiple text/data sections and rely on the linker to remove those that are not used. It is useful in the context of RSP reusable code libraries.
While writing vectorized RSP code, it is quite useful to have a zero register (initialized to all zero) and also various power of twos to implement shifts. This commit changes rspq so that any time it calls a function in an overlay, it first initializes $v00 to zero, and $v30/$v30 with the constants required to implement the shift macros (see rsp.inc).
a different name so to be able to combine both if required):
…ail. This allows to commit log messages in tests, as they don't pollute the debugging spew. The text will be shown if the test ever fails. Also introduce a ERR() macro for text that should be displayed on both stdout and stderr, again only when the test fails.
We shouldn't apply the scanline shifting logic in non-interlaced modes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another set of unrelated changes coming from the OpenGL. These can be merged safely even right now.