Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getting the following error after 2:30min was a bit scary 😅
with that change and rust-lang/rust#119735
cargo +rust1 rustc -- -Znext-solver
compiles successfully in 4m26,600s after changing the recursion limit to 1024. Unsure what exactly is responsible for the higher recursion limit requirement, but tbh, I don't care too much about that.RUSTFLAGS=-Znext-solver time cargo +rust1 test
takes nearly 13 minutes, can probably trivially speed this up by deduplicating obligations in the new solver as well 🤷