Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first draft of rpt code hackthon #3

Conversation

ganmad
Copy link

@ganmad ganmad commented Mar 29, 2023

Description

The draft notebook simulated degradation cycling at 1C/1C and carries out RPT (reference performance test) to find out C/3 discharge capacity for each 10 cycles. The capacity vs cycle number was plotted.
Created with the help of Steve Kench.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@DrSOKane DrSOKane merged commit e54ef31 into DrSOKane:issue-2219-initial-SoC-from-experiment Mar 29, 2023
DrSOKane pushed a commit that referenced this pull request Jul 11, 2023
Accept Ruihehackathon changes by Jon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants