Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker file changes] -> Merged install dependencies and miniforge to… #47

Closed
wants to merge 1 commit into from

Conversation

Jagadeesh-ajjada
Copy link
Collaborator

[Docker file changes] -> Merged install dependencies and miniforge to make build faster by keeping cache less, downgrade the python version Make sure all packages (like langchain and faiss-cpu) are compatible with Python version over the operating systems, and combined the duplicate entry between SHELL and CMD.

… make build faster by keeping cache less, downgrade the python version Make sure all packages (like langchain and faiss-cpu) are compatible with Python version over the operating systems, and combined the duplicate entry between SHELL and CMD.
@itsnotmik
Copy link
Collaborator

Not based on the newest commit on main which has made significant Dockerfile changes.

Also can you provide documentation (links) for why python 3.11 is required

@ACraig7
Copy link
Collaborator

ACraig7 commented Sep 14, 2024

Conflicts with main branch and does not install dependencies from requirements.txt since RUN pip install -r /app/requirements.txt is commented out.

@ACraig7 ACraig7 closed this Sep 14, 2024
@Jagadeesh-ajjada
Copy link
Collaborator Author

It is obvious that more than 1 person can work on same page that is why we have merge conflicts concept and you said the branch is not based on the newest commit on main the time i took branch out and started working on it, whatever the newest i took that only.
and you said in the docker discussion that, "the only solutions I have seen is to switch to conda cause it uses less memory but I don't think we can do that". and also check this: jupyterlab/jupyter-ai#538

@itsnotmik
Copy link
Collaborator

Yes normally this wouldn't be a problem but we made significant changes to the structure of the Dockerfile. This prevented a autonomous merge (hence the merge conflict). So we can not merge it because it is not using the updated main code.

Thank you for the link, but are we using Jupyter-AI? I assumed we were only using the Jupyter notebook though, if we need Jupyter-AI then we can make the switch

@itsnotmik itsnotmik deleted the docker_file_changes branch October 8, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants