Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp code highlighting issue (#27) #27

Merged
merged 3 commits into from
Jan 19, 2018
Merged

cpp code highlighting issue (#27) #27

merged 3 commits into from
Jan 19, 2018

Conversation

ksakash
Copy link
Contributor

@ksakash ksakash commented Jan 16, 2018

{% highlight c++ %} .... {% endhighlight %} not working, for all the .md files in the docs, so replaced it with ```cpp....```

@Dovyski
Copy link
Owner

Dovyski commented Jan 16, 2018

Thank you for your contribution and help!

Could you please tell me a bit more about how they are not working? I've just checked cvui's online docs, e.g. button page, and {% highlight c++ %} .... {% endhighlight %} is working.

Did you encounter the problem while trying to render the docs locally using jekyll?

@ksakash
Copy link
Contributor Author

ksakash commented Jan 16, 2018

Not locally, but when i was reading the docs on github repo.

@Dovyski
Copy link
Owner

Dovyski commented Jan 17, 2018

Oh, I see. Your solution is much better (I didn't like the {% highlight%} thing). I will just check the changes locally before accepting the pull request.

@Dovyski Dovyski changed the title cpp code highlighting issue Improve docs by replacing highlight tags with a markdown equivalent Jan 19, 2018
@Dovyski Dovyski changed the title Improve docs by replacing highlight tags with a markdown equivalent cpp code highlighting issue (#27) Jan 19, 2018
@Dovyski Dovyski merged commit 3242303 into Dovyski:master Jan 19, 2018
@Dovyski
Copy link
Owner

Dovyski commented Jan 19, 2018

All changes have been merged. Thank you very much for your time and contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants