Skip to content

Add TinyECS

Add TinyECS #36

Triggered via pull request April 29, 2024 03:10
Status Failure
Total duration 1m 12s
Artifacts

PullRequest.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 2 warnings
pull_request: source/Ecs.CSharp.Benchmark/Contexts/TinyEcsBaseContext.cs#L15
Provide an overridable implementation of Dispose(bool) on 'TinyEcsBaseContext' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
pull_request: source/Ecs.CSharp.Benchmark/Contexts/TinyEcsBaseContext.cs#L24
Modify 'TinyEcsBaseContext.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
pull_request: source/Ecs.CSharp.Benchmark/Contexts/TinyEcsBaseContext.cs#L24
Change TinyEcsBaseContext.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
pull_request: source/Ecs.CSharp.Benchmark/Contexts/TinyEcsBaseContext.cs#L15
Provide an overridable implementation of Dispose(bool) on 'TinyEcsBaseContext' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
pull_request: source/Ecs.CSharp.Benchmark/Contexts/TinyEcsBaseContext.cs#L24
Modify 'TinyEcsBaseContext.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
pull_request: source/Ecs.CSharp.Benchmark/Contexts/TinyEcsBaseContext.cs#L24
Change TinyEcsBaseContext.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
pull_request
Process completed with exit code 1.
pull_request
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-dotnet@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
pull_request
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/