Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert internal api to v2beta1 #224

Merged
merged 5 commits into from
Sep 19, 2024
Merged

fix: revert internal api to v2beta1 #224

merged 5 commits into from
Sep 19, 2024

Conversation

raffis
Copy link
Member

@raffis raffis commented Sep 19, 2024

Current situation

flux-build v3 uses only the v2 api version of Helmreleases just as the helm-controller from flux v2.
However this was a poor design choice since this basically drops support for some features used in the beta apis such as postrender patches in the deprecated format.
While for a controller it makes sense to only work with a certain version (withouth conversion) for flux-build there is no reason to drop support as different apiVersions might be used at the same time and a controller only works with one.

Proposal

Partially revert the api changes and go back to the beta one. The advantage of the beta one is it supports both the deprecated and the new fields.
This change is fully backwards compatible, it only changes flux-build internals.

@raffis raffis requested a review from a team as a code owner September 19, 2024 09:57
@coveralls
Copy link

coveralls commented Sep 19, 2024

Pull Request Test Coverage Report for Build 10938745220

Details

  • 46 of 131 (35.11%) changed or added relevant lines in 5 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 50.351%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/helm/postrenderer/post_renderer_namespace.go 0 1 0.0%
internal/helm/postrenderer/post_renderer_origin_labels.go 5 9 55.56%
internal/helm/postrenderer/post_renderer.go 0 11 0.0%
internal/helm/postrenderer/post_renderer_kustomize.go 41 56 73.21%
internal/build/helm.go 0 54 0.0%
Files with Coverage Reduction New Missed Lines %
internal/build/helm.go 1 0.0%
internal/helm/postrenderer/post_renderer_origin_labels.go 2 64.71%
internal/helm/postrenderer/post_renderer_kustomize.go 2 74.56%
Totals Coverage Status
Change from base Build 10937017279: -0.08%
Covered Lines: 1649
Relevant Lines: 3275

💛 - Coveralls

@raffis raffis merged commit 01cf94a into master Sep 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants