fix: revert internal api to v2beta1 #224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation
flux-build v3 uses only the v2 api version of Helmreleases just as the helm-controller from flux v2.
However this was a poor design choice since this basically drops support for some features used in the beta apis such as postrender patches in the deprecated format.
While for a controller it makes sense to only work with a certain version (withouth conversion) for flux-build there is no reason to drop support as different apiVersions might be used at the same time and a controller only works with one.
Proposal
Partially revert the api changes and go back to the beta one. The advantage of the beta one is it supports both the deprecated and the new fields.
This change is fully backwards compatible, it only changes flux-build internals.