Unsafe int cast in kill command (backport cometbft#783) (cometbft#793)

* Unsafe int cast in `kill` command (cometbft#783) * Unsafe int cast in `kill` command * Revert "Unsafe int cast in `kill` command" This reverts commit bbd649b. * Changed strategy (cherry picked from commit 03c5e77) # Conflicts: # cmd/cometbft/commands/debug/kill.go * Revert "Unsafe int cast in `kill` command (cometbft#783)" This reverts commit 5cf3226. * Unsafe int cast in `kill` command (cometbft#783) * Unsafe int cast in `kill` command * Revert "Unsafe int cast in `kill` command" This reverts commit bbd649b. * Changed strategy --------- Co-authored-by: Sergio Mena <[email protected]>
DongCoNY · May 13, 2024 · 9b53541 · 9b53541
1 parent 00f3cec
commit 9b53541
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/cmd/cometbft/commands/debug/kill.go b/cmd/cometbft/commands/debug/kill.go
@@ -33,7 +33,7 @@ $ cometbft debug 34255 /path/to/cmt-debug.zip`,
 }
 
 func killCmdHandler(cmd *cobra.Command, args []string) error {
-	pid, err := strconv.ParseUint(args[0], 10, 64)
+	pid, err := strconv.Atoi(args[0])
 	if err != nil {
 		return err
 	}
@@ -100,7 +100,7 @@ func killCmdHandler(cmd *cobra.Command, args []string) error {
 // is tailed and piped to a file under the directory dir. An error is returned
 // if the output file cannot be created or the tail command cannot be started.
 // An error is not returned if any subsequent syscall fails.
-func killProc(pid uint64, dir string) error {
+func killProc(pid int, dir string) error {
 	// pipe STDERR output from tailing the CometBFT process to a file
 	//
 	// NOTE: This will only work on UNIX systems.
@@ -123,7 +123,7 @@ func killProc(pid uint64, dir string) error {
 	go func() {
 		// Killing the CometBFT process with the '-ABRT|-6' signal will result in
 		// a goroutine stacktrace.
-		p, err := os.FindProcess(int(pid))
+		p, err := os.FindProcess(pid)
 		if err != nil {
 			fmt.Fprintf(os.Stderr, "failed to find PID to kill CometBFT process: %s", err)
 		} else if err = p.Signal(syscall.SIGABRT); err != nil {