Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PR validation using github actions #481

Merged
merged 3 commits into from
Mar 5, 2020
Merged

Added PR validation using github actions #481

merged 3 commits into from
Mar 5, 2020

Conversation

ole1986
Copy link
Contributor

@ole1986 ole1986 commented Mar 5, 2020

No description provided.

@ole1986
Copy link
Contributor Author

ole1986 commented Mar 5, 2020 •
edited
Loading

Since prettier and linter is now part of the eslint configuration the github action uses vscode:prepublish to validate the PR.

@DonJayamanne shall the Github Action also autofix and commit?

@ole1986 ole1986 merged commit 58799cf into master Mar 5, 2020
@ole1986 ole1986 deleted the pr-action branch March 13, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ole1986 @DonJayamanne