Lint vs gulp #471
Lint vs gulp #471
Conversation
|
I hated what u did with gulp as well. |
I'd prefer to use eslint and prettier.
use jest for coverage. FYI. Please feel free to checkout the projects under https://github.com/DonJayamanne/gitHistoryVSCode/projects/2 and assign some to your self. Once we have eslint, prettier and the like locally, we can move them to GitHub actions, separate phase/project https://github.com/DonJayamanne/gitHistoryVSCode/projects/4 Summarizing:
By start locally, i mean have scripts in package.json setup so we can use it locally, then when happy that things are ok, separate PR to get into github actions. |
ole1986
changed the base branch from
master
to
replace-webserver-with-postmessage
ole1986
force-pushed
the
lint-vs-gulp
branch
from
471b0c3 to
13139ef
Compare
ole1986
force-pushed
the
lint-vs-gulp
branch
from
13139ef to
96ccb84
Compare
|
I am not quite sure about jest. Since the only supported seem to be mocha (microsoft/vscode#67619 (comment)) At least i corrected the parser.test.ts in unit testing for fileStat |
|
Also, some tests may be unnecessary due to the use of vscode git extension. (E.g. RefsParser) |
It is possible, that's an old comment, also I've used it Let's leave that for another PR |
* removing gulp while running tslint --fix while committing * use object instead of any for IPostMessage * replaced tslint ans tsfmt with eslint and prettier * added some exceptional rules in eslintrc * eslint --fix incl. prettier on src/ * Resolved unit test issues by properly using tabs as expected * slightly corrected launch.json * Use git extension api to fetch refs and remove RefParser * removed old codecoverage from .travis.yml * set the webpack maxAssetSize and maxEntrypointSize to 700kb * no sourcemap for production * use nodejs v10 in .travis
* removing gulp while running tslint --fix while committing * use object instead of any for IPostMessage * replaced tslint ans tsfmt with eslint and prettier * added some exceptional rules in eslintrc * eslint --fix incl. prettier on src/ * Resolved unit test issues by properly using tabs as expected * slightly corrected launch.json * Use git extension api to fetch refs and remove RefParser * removed old codecoverage from .travis.yml * set the webpack maxAssetSize and maxEntrypointSize to 700kb * no sourcemap for production * use nodejs v10 in .travis
* removing gulp while running tslint --fix while committing * use object instead of any for IPostMessage * replaced tslint ans tsfmt with eslint and prettier * added some exceptional rules in eslintrc * eslint --fix incl. prettier on src/ * Resolved unit test issues by properly using tabs as expected * slightly corrected launch.json * Use git extension api to fetch refs and remove RefParser * removed old codecoverage from .travis.yml * set the webpack maxAssetSize and maxEntrypointSize to 700kb * no sourcemap for production * use nodejs v10 in .travis
* Initial start of postMessage implementation * No need for localResourceRoots as the extensionPath is already included * Recovered authorFilter search * Fixed branches dropdown not updating selection * Implemented MessageBus using Promise with unique requestId * fixed paging * Fixed fsPath in Uri is unavailable during postMessage * replaced FsUri with native Uri * Fixed #472 * Update package-lock.json * Lint vs gulp (#471) * recovered detached head in branch dropdown #167 * use node-fetch to grab github avatars * fetch avatars only once when opening * Fixed file status images not shown * fix ts error using any type in githubUsers * Update dependencies while fixing related issues (#473) * Updated CHANGELOG.md * configure webpack to disable polyfill on node * corrected resourcePath due to the bundled extension.js * cleanup dist directory at webpack start * Fixed #400 #289 by counting the commits using rev-list (#475)
I assume the reason of #455, #454 and #447 #448 is also to reduce such tools on developer side and automate it using Github action (or similar) during PR merge.
To be honest I did not know the reason of gulp and havent used it (except the hygiene check).
I always had the impression that this was kinda overdressed.
So what does this PR contain?
tslintduringgit committslint.jsontslint --fixthe whole src/ directory while fixing the issue to become successfulWhats next?
typescript-formatterlocally on every commit?@DonJayamanne please let me know what you think about it.