Replace git command with git extension api (1/2) #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ole1986
force-pushed
the
git-api
branch
4 times, most recently
from
f9743fa to
b4725b5
Compare
|
@DonJayamanne would you mind checking this PR? Especially the use of submodules (or multiple git repositories in same workspace) as the behavior has slightly changed |
ole1986
force-pushed
the
git-api
branch
2 times, most recently
from
ff65444 to
e41f951
Compare
ole1986
force-pushed
the
git-api
branch
4 times, most recently
from
d33777c to
a9f9fbf
Compare
added 11 commits
February 7, 2020 08:58
added 5 commits
February 7, 2020 09:04
added 6 commits
February 7, 2020 14:38
ole1986
changed the title
|
I think I am going to split this into two parts since vscode related issues are not yet included in the last insider version |
DonJayamanne
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets on replacing git commands with the native git extension API (v1).
The following parts will be replaced with this PR
Also, some methods related to git may have be removed (like
getHash) as they are no longer in neededPLEASE NOTE: Behavior has changed for repositories
In previous versions a prompt may appear for existing repositories (E.g. submodules) from inside the workspace. In future this is also handled by the Git Extension API which may require to select the repository from source code provider side bar before running the command Git History (git log)