-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read current remote name (defaulting to origin) #318
Conversation
Fixes #281 |
Still a problem here. In my case it needs to execute |
I just checked, and as I mentioned in the comment of this PR, my change was totally untested 😅 #330 should fix it though… |
I think that #330 it is already in a release. Right? So it is not fixed cause I've an updated version of the plugin. |
It's released to the releases page but it's not released to the extension marketplace from what I can see… I also checked for updates in VS Code and I'm still on 0.4.3 |
Ok thanks so we need to wait for the Marketplace push. |
For what it's worth, I am on 0.4.4 and still have his error. |
@ludaavics what output do you get when entering the below command?
|
OK after some playing around, here is how to replicate: # on dev branch -- no error
$ git status --porcelain=v1 -b --untracked-files=no
## dev...github/dev
# create a new branch -- errors out
$ git checkout -b foo
$ git status --porcelain=v1 -b --untracked-files=no
## foo
# push new branch -- still errors out
$ git push github foo
$ git status --porcelain=v1 -b --untracked-files=no
## foo
# set upstream -- back to no error
$ git push --set-upstream github foo
$ git status --porcelain=v1 -b --untracked-files=no
## foo...github/foo |
Hey, since i'm seeing the following dreaded error message in the Output panel
This happens when there are no remotes called origin (am I the only way that gives descriptive names to remotes?). I tried to look into the issue, and came up with this pull request. It is in no way tested, since I don't know how to "compile" an extension for testing. So take it as it is and fix it in case, or tell me what I need to change.