getGitReposInFolder: fix async folder filtering #311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folder filtering in
Git.getGitReposInFolder()
is not working as intended, because the
filter()
callback returns aPromise
, which is a truthy value, sofilter()
just passesfilteredItems
through, andPromise.all()
does the same (as the array values are strings, notPromise
s), so in the endfolders
is a copy offilteredItems
.Fixes #143 .
Note: I adapted
asyncFilter()
implementation from this StackOverflow answer.