Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravatar not working #436

Closed
nesslopz opened this issue Feb 12, 2020 · 7 comments
Closed

Gravatar not working #436

nesslopz opened this issue Feb 12, 2020 · 7 comments

Comments

@nesslopz
Copy link

nesslopz commented Feb 12, 2020

Hi! New update is awesome, great features, but since >0.4.16 I can't see gravatar pictures, it's broken.
It works on 0.4.15

Also, on git history command it asks for repository, inclusive if there's only 1 choice.

Thanks 👍

@ole1986
Copy link
Contributor

ole1986 commented Feb 12, 2020

Thank you for reporting,

Can you please provide me with the remote you are expecting to have gravatar pictures.
UPDATE: I assume its vsts

@ole1986 ole1986 closed this as completed Feb 12, 2020
@nesslopz
Copy link
Author

nesslopz commented Feb 12, 2020

Hi! I'm sorry, I upload screenshots

This is how looks on a Private Bitbucket repository:
Log: Screen Shot 2020-02-12 at 2 24 37 PM

Commit detail: Screen Shot 2020-02-12 at 2 24 45 PM

And with a Public GitHub repository it doesn't show nothing as photo
Log: Screen Shot 2020-02-12 at 2 25 01 PM

Commit detail: Screen Shot 2020-02-12 at 2 25 09 PM

Still not working on v0.5.1

@ole1986 ole1986 reopened this Feb 12, 2020
@ole1986
Copy link
Contributor

ole1986 commented Feb 12, 2020

Can you please open the Developer Webview when Git History is opened
image

and tell me what is shown in one of the log entries img source, like shown below?

image

@ole1986
Copy link
Contributor

ole1986 commented Feb 12, 2020

Also for testing purposes you can try to disable the Avatar Cache through setting gitHistory.avatarCacheExpiration

image

@ole1986
Copy link
Contributor

ole1986 commented Feb 13, 2020

OMG I forgot to push the changes.
Fixes will be available with 0.5.2.

Sorry

@nesslopz
Copy link
Author

Hi! I'm sorry I was not able to test as you told me, because I was out of office. But I confirm is working back in 0.5.2. Thank you so much 👍

(offtopic: do you have any guide for extension development, apart of documentacion, I'm working in a extension too but is very simple and saw your code it's really impresionant)

@ole1986
Copy link
Contributor

ole1986 commented Feb 13, 2020

There is a CONTRIBUTING.md (which i just noticed is outdated due to the removed submodule)

All rights for the code go to @DonJayamanne
I am just a little code helper ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants