Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken commit comparison (select / compare) #326

Closed
ole1986 opened this issue Oct 4, 2018 · 3 comments
Closed

Broken commit comparison (select / compare) #326

ole1986 opened this issue Oct 4, 2018 · 3 comments

Comments

@ole1986
Copy link
Contributor

ole1986 commented Oct 4, 2018

not to confused with the file file comparison it seems that the commit compare feature is broken, too

When I try to select a commit and afterwards choice the "Compare with..." nothing actually happens

image

image

I haven't used this feature at all and actually do not know what the outcome is supposed to be.
Will double check the source, but maybe someone can explain me this?!

@ole1986
Copy link
Contributor Author

ole1986 commented Oct 9, 2018

For of you who searched for the results, its actually compare Commits view which is simple not focused when the command is being executed.

This view can be focus using >Explorer: Focus on Compare Commits View command

@DonJayamanne
Copy link
Owner

I need to test this my self. The user shouldn't have to set focus, we should do it for them.

@DonJayamanne
Copy link
Owner

Awesome, thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants