Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(release): add crates.io release job #26

Closed
wants to merge 1 commit into from
Closed

ci(release): add crates.io release job #26

wants to merge 1 commit into from

Conversation

DonIsaac
Copy link
Owner

No description provided.

@DonIsaac DonIsaac added the ci Changes to CI/CD setup label Sep 19, 2024
This was referenced Sep 19, 2024
Closed
Closed
ashleygwilliams
ashleygwilliams reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! so i think this is on the right path, but we should use the custom jobs feature in cargo-dist- this file is generated and managed by the tool and so it will flag that this is dirty and complain in CI

.github/workflows/release.yml
@@ -266,10 +282,30 @@ jobs:

gh release create "${{ needs.plan.outputs.tag }}" --target "$RELEASE_COMMIT" $PRERELEASE_FLAG --title "$ANNOUNCEMENT_TITLE" --notes-file "$RUNNER_TEMP/notes.txt" artifacts/*

# Publish oxbuild to crates.io
publish-crates:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should pull this out into a separate workflow file and register it as a "publish job" in config

.github/workflows/release.yml
@@ -45,6 +45,22 @@ on:
- '**[0-9]+.[0-9]+.[0-9]+*'

jobs:

# Make sure we're not releasing broken code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add this as a pre-build setup step if you want

@DonIsaac
Copy link
Owner Author

@ashleygwilliams I'm reading your section on cargo-release compatability; would it just make more sense to run cargo release locally, have it bump the version/create the tag, then have cargo dist get triggered afterwards?

@DonIsaac
Copy link
Owner Author

Closing in favor of cargo release

@DonIsaac DonIsaac closed this Sep 19, 2024
@DonIsaac DonIsaac deleted the don/ci/publish-crates branch September 19, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleygwilliams ashleygwilliams ashleygwilliams left review comments

Assignees
No one assigned
Labels
ci Changes to CI/CD setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonIsaac @ashleygwilliams