-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --ac-only argument to start autoupdate only when device is not running on battery power #112
Open
swissbuechi
wants to merge
17
commits into
DomT4:master
Choose a base branch
from
swissbuechi:run-only-on-AC
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ff01760
Added --ac-only argument to start command
swissbuechi d00ab5e
Fix "useless assignment to variable"
swissbuechi 46790ef
Merge branch 'master' into run-only-on-AC
swissbuechi 24f4976
Merge branch 'master' into run-only-on-AC
swissbuechi 37b0e1d
Merge branch 'master' into run-only-on-AC
swissbuechi 0f0df32
Merge branch 'master' into run-only-on-AC
swissbuechi 0b54cd5
Merge branch 'master' into run-only-on-AC
swissbuechi f803498
Merge branch 'master' into run-only-on-AC
swissbuechi 89e247f
Merge branch 'master' into run-only-on-AC
swissbuechi 15a31ce
Merge branch 'master' into run-only-on-AC
swissbuechi 53739e6
Merge branch 'master' into run-only-on-AC
swissbuechi f626b0e
Merge branch 'master' into run-only-on-AC
swissbuechi c5d244a
Update README.md with --help output
github-actions[bot] 4c0a146
Merge branch 'master' into run-only-on-AC
swissbuechi a8b2813
fixed syle
swissbuechi 9055f41
Fixed style
swissbuechi 760f297
Brew syle
swissbuechi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this print to the applet notification? Will the user be notified essentially that Autoupdate hasn't actually been run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole
autoupdate
script will not run, so no applet notification will be shown.The users will not be notified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the
autoupdate
script ever start or is it essentially "stuck" until the user tries to activate it again? That's my only concern here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This time, I'm sorry for the late reply, totally missed it.
It will only run, if the user ever again plugs in power (what he's very likely to do since he want's to continue using the device) and another trigger (reboot or time) initiates the execution of the autoupdate script.