Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Introduce visual regression tests using Playwright #732

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gnapse
Copy link
Contributor

@gnapse gnapse commented Dec 29, 2022

Short description

Work in progress.

See https://twist.com/a/1585/ch/607587/t/3963022/

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Updated all static build artifacts (npm run build-all)

Versioning

@gnapse gnapse self-assigned this Dec 29, 2022
@gnapse gnapse force-pushed the ernesto/vrt/playwright branch 9 times, most recently from 87f3f88 to 32dd32f Compare December 29, 2022 16:51
@gnapse
Copy link
Contributor Author

gnapse commented Jan 3, 2023

Something introduced in this PR has broken the tsdx build command. I noticed first on CI, but when I run it locally I can reproduce. To do so, run this command locally:

tsdx build --tsconfig tsconfig.dist.json

The closest I've found online related to the error message is rollup/rollup#3591. Maybe tsdx is using a rollup version older than the one in which a fix for that issue was released. Meaning we really need to get rid of tsdx soon.

@henningmu
Copy link
Contributor

Maybe tsdx is using a rollup version older than the one in which a fix for that issue was released

According to package-lock, tsdx is using 2.79.1. The fix went live with 2.11.0. Must be something else 😞

Meaning we really need to get rid of tsdx soon

This is true regardless, and might be the easier solution than figuring out the root cause here 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants