Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade dependencies #18

Merged
merged 2 commits into from
Jul 5, 2022
Merged

chore: upgrade dependencies #18

merged 2 commits into from
Jul 5, 2022

Conversation

miottid
Copy link
Member

@miottid miottid commented Jul 1, 2022 •
edited
Loading

We're stuck upgrading dependencies on a couple of our repositories. See https://github.com/Doist/Doist-Emails/pull/1706.

This PR upgrade devDependencies to their latest and allow any version of React as peerDependencies. With that, we will be able to upgrade React to 18 on the Doist-Emails.

Once merged, I'll proceed with a release of this package.

Test

  • Delete the node_modules and re-install them npm i.
  • npm run test should report no errors.

@miottid miottid self-assigned this Jul 1, 2022
@miottid miottid requested review from a team and JefCurtis and removed request for a team July 1, 2022 11:11
JefCurtis
JefCurtis approved these changes Jul 4, 2022
View reviewed changes
Copy link

@JefCurtis JefCurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test and build runs finished successfully on my local so I'm ok signing off on this but allowing any version of React seems very permissive. Considering this is a public repo, do you think we should constrain the versions to the last few? Just a thought.

@miottid
Copy link
Member Author

miottid commented Jul 5, 2022

Agreed, I configured a minimum react and react-dom version 👍🏻

@miottid miottid merged commit 0a0a885 into main Jul 5, 2022
@miottid miottid deleted the miottid/upgrade-deps branch July 5, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JefCurtis JefCurtis JefCurtis approved these changes

Assignees

@miottid miottid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miottid @JefCurtis