added support for a custom advancement on first time passing an exam #3
Conversation
There was a problem hiding this comment.
Currently this only supports one advancement - for completing an exam.
Moreover, this one advancement requires a datapack - which is not a part of the standalone plugin.
If this would be a part of the plugin, which is kind of a standalone thing for servers, which doesn't require a datapack in and of itself, it would probably be nice if you added so there, in the exams' config file, for each exam, is an advancement that you can list, like so:
CitizenEnglish:
RankName: citizen
Command: give $PlayerName 38 1
NumberOfQuestions: 10
Advancement: doggycraft:doggycraft/citizen
Questions:
How do i set a home?:
And then have the plugin add that advancement to the player.
And even then, you could just do:
CitizenEnglish:
RankName: citizen
Commands:
- give $PlayerName 38 1
- advancement grant $PlayerName only doggycraft:doggycraft/citizen
NumberOfQuestions: 10
Questions:
How do i set a home?:
|
|
||
| // giving player an advancement for passing an exam if set to true | ||
| if (plugin.grantAdvancement) { | ||
| Advancement a = Bukkit.getAdvancement(NamespacedKey.fromString(plugin.examAdvacementName)); |
There was a problem hiding this comment.
Could be changed to see if the exam has an Advancement specified.
There was a problem hiding this comment.
agree on the part of the if(plugin.grantAdvancement) check
There was a problem hiding this comment.
For now one advancement works as a prof of concept.
The reason you can turn this feature on and of is exactly because people might not have a datapack on their server or want to have one. And it does not have to be a specific datapack. Thats why it can be change in the config.yml so people can create their own datapacks with the advancement they what to give.
|
|
||
| public String serverName = "Your Server"; | ||
| public String languageFilename = "english.yml"; | ||
| public String examAdvacementName = "doggycraft:doggycraft/student"; |
There was a problem hiding this comment.
This is a hardcoded advancement, for completing your first exam.
Would be better to move to the config file for the exams, to have custom per-exam advancements.
Or specify more precisely, that this advancement is a one-time advancement, by calling it something like "firstExamAdvancement".
There was a problem hiding this comment.
agree on naming but the "hardcoded" bit is just a default value. it is change later when the config is loaded.
added advancement feature to Exams plugin