-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add playground application #53
Conversation
529855d
to
52e9ca1
Compare
52e9ca1
to
7b6b510
Compare
@gabestein and @sheishistoric , feedback was that looking up docmap by DOI of a review object should produce docmap for the preprint it reviews. However, I'm realizing that we had decided something different last time we talked about that: see discussion on #49 and #48 . I am inclined to let the precedent stand, which means to pull this in without handling the "look up by review" case. But I should fix the erroring behavior now, by essentially saying "we can't construct a docmap for this item, because it is a review; look up the preprint instead." maybe with helpful link. I think that would make the SPA's behavior clear and coherent enough when user attempts this, without the complexity increase that we would pick up with #48 . Alternatively, we could change the desired behavior in #49 so that it returns a full docmap for the preprint; or implement that as an interim behavior expecting it to change (my least favorite of the options.) |
and set groundwork for graph-walk algorithm instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This new application is a simple stateless web app that allows you to visualize a docmap based on our Crossref-to-Docmap ETL library.
How to review
Take a gander over at the github pages hosting the app. You can plug in any DOI, and if crossref knows about it and it has reviews or a preprint, you'll get some interesting content back. A good one to start with is
10.5194/angeo-40-247-2022
.Then glance over the code.
It relies on updates to
render-rev
that I have submitted via source-data/render-rev#2 . Once that is merged, we can stop using the awkward fork-branch syntax for the new dependency.It also relies on changes to the
ts-etl
package which are included in this PR. they should be released together automatically bymulti-semantic-release
.Note that because the SPA is so minimal in logic it doesn't currently have lint or tests.
Related Issues
Resolves #45
Mutual with #15
Depends on #42
Checklist
Additional Information
Implemented using Svelte.