Ships/revert preconstruct #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts the packaging choices made in #59 .
Preconstruct is not compatible with
type: modulepackages. While the adoption of preconstruct and conversion to CommonJS is a possibility and has some known upsides, it is not clearly the right way forward, and would introduce some trouble such as with ESM module dependencies ofts-sdk. So I am punting on this resolution for now.I also added
manypkgas a workspace tool to improve linking and tooling for monorepo.Related Issues
Reopens #57 , which was not actually resolved.
Checklist
Additional information
See #57's new comments for info about what we learned .