Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release all packages with CJS and MJS versions #57

Closed
ships opened this issue May 16, 2023 · 1 comment · Fixed by #59 or #94
Closed

Release all packages with CJS and MJS versions #57

ships opened this issue May 16, 2023 · 1 comment · Fixed by #59 or #94
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ships
Copy link
Collaborator

ships commented May 16, 2023

For compatibility with non-TS users.

see preconstruct.tools ?
@ships ships mentioned this issue May 16, 2023
Merged
4 tasks
@ships ships closed this as completed in #59 May 17, 2023
@ships ships mentioned this issue May 17, 2023
Merged
4 tasks
@ships ships reopened this May 17, 2023
@ships
Copy link
Collaborator Author

ships commented May 17, 2023

#59 actually broke the released packages because the preconstruct tool does not support building module type packages. Also see this preconstruct proposal which might enable this in future.

The main issues we face if we abandon ESM: AVA (test framework) runs as a module, and some dependencies (at least @rdfjs/rdf-serializer-ext) are modules.

@ships ships added enhancement New feature or request help wanted Extra attention is needed labels May 17, 2023
@ships ships mentioned this issue Jul 18, 2023
Merged
4 tasks
@ships ships closed this as completed in #94 Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
1 participant
@ships