Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: use preconstruct for production building #59

Merged
merged 3 commits into from
May 17, 2023
Merged

WIP: use preconstruct for production building #59

merged 3 commits into from
May 17, 2023

Conversation

ships
Copy link
Collaborator

@ships ships commented May 16, 2023 •
edited
Loading

Description

This PR adds preconstruct as a workspace root dependency and integrates it into the release train.
This should enable the packages released from this monorepo to easily integrate into consumers regardless of whether those consumers use ESM, CJS, native TS, etc.

Related Issues

Resolves #57

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added or updated tests to cover any new functionality or bug fixes.
  • I have updated the documentation to reflect any changes or additions to the project.
  • I have followed the project's code of conduct and conventions for commit messages.

Additional Information

@ships
Copy link
Collaborator Author

ships commented May 16, 2023

@3mcd, another place i would love your eyes! Thx

@ships ships force-pushed the ships/add-preconstruct-packaging branch from 59be8c0 to f77a6b1 Compare May 16, 2023 22:33
3mcd
3mcd approved these changes May 16, 2023
View reviewed changes
Copy link

@3mcd 3mcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ships ships merged commit 9d9ae42 into main May 17, 2023
ships added a commit that referenced this pull request May 17, 2023
@ships
Revert "feat(@docmaps/etl,docmaps-sdk): use preconstruct for producti…
ff55df8 
…on building (#59)"

This reverts commit 9d9ae42.
This was referenced May 17, 2023
Merged
Closed
ships added a commit that referenced this pull request May 17, 2023
@ships
feat(docmaps-sdk, @docmaps/etl): Revert preconstruct (#61)
f31747c 
Revert #59: 
This reverts commit 9d9ae42

* add manypkg
@ships ships deleted the ships/add-preconstruct-packaging branch August 22, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3mcd 3mcd 3mcd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release all packages with CJS and MJS versions
2 participants
@ships @3mcd