Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #3

Merged
merged 2 commits into from
Jul 21, 2016
Merged

Minor fixes #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6058a8e
es-lint fix
bennycwong Jul 21, 2016
d4b0878
add circle
bennycwong Jul 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
repo_token: $COVERALLS_REPO_TOKEN
8 changes: 6 additions & 2 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,12 @@ tests/fixtures/**/*
tmp/**/*
vendor/**/*

app/router.js
public/assets/js/skrimps.js
# Generated files
index.js
testem.js
tests/test-helper.js
tests/dummy/*
tests/helpers/*

# runs in Phantom, which lacks support for required ES2016 features
tests/blanket-options.js
8 changes: 1 addition & 7 deletions ,eslintrc.json → .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,5 @@
],
"plugins": [
"dollarshaveclub"
],
"globals": {
"Fingerprint": true,
"Flickity": true,
"Modernizr": false,
"Raven": true
}
]
}
6 changes: 3 additions & 3 deletions tests/unit/mixins/router-scroll-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import { module, test } from 'qunit';
module('Unit | Mixin | router scroll');

// Replace this with your real tests.
test('it works', function(assert) {
let RouterScrollObject = Ember.Object.extend(RouterScrollMixin);
let subject = RouterScrollObject.create();
test('it works', (assert) => {
const RouterScrollObject = Ember.Object.extend(RouterScrollMixin);
const subject = RouterScrollObject.create();
assert.ok(subject);
});