Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ember-app-scheduler to the latest #283

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

SergeAstapov
Copy link
Contributor

Allow consumer apps to use latest ember-app-scheduler.

Release notes: https://github.com/ember-app-scheduler/ember-app-scheduler/releases/tag/v6.0.0

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank yoU!!

@snewcomer snewcomer merged commit 9b45ac7 into DockYard:master Jun 17, 2021
@SergeAstapov SergeAstapov deleted the upgrade-ember-app-scheduler branch June 17, 2021 21:13
@Turbo87
Copy link
Collaborator

Turbo87 commented Jun 18, 2021

isn't this a breaking change for users that use a different/conflicting version?

@SergeAstapov
Copy link
Contributor Author

@Turbo87 considering the only breaking change in [email protected] - removed some deprecated APIs which are not used by ember-router-scroll, I would say no.

However this may become extra work for those who use both ember-app-scheduler and ember-router-scroll without package lock/yarn lock in case if app is not ready for [email protected]. then ember-router-scroll needs to use ~4.0.0 in package.json (to avoid issues described in https://github.com/salsify/ember-cli-dependency-lint#motivation).

it may be safer (in my opinion) to release as major version bump just to avoid potential issues for apps that use both ember-app-scheduler and ember-router-scroll without ember-cli-dependency-lint integrated with CI.

@Turbo87
Copy link
Collaborator

Turbo87 commented Jun 18, 2021

I think the safe thing to do is something like "ember-app-scheduler": "^5.1.2 || ^6.0.0". That way you can let the user decide which version he wants to have.

@SergeAstapov
Copy link
Contributor Author

@Turbo87 great suggestion! Created #284.

@snewcomer do you mind to release #284 as 4.1.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants