Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Evented trigger didScroll #246

Merged
merged 3 commits into from
Mar 4, 2020
Merged

Add Evented trigger didScroll #246

merged 3 commits into from
Mar 4, 2020

Conversation

snewcomer
Copy link
Collaborator

@snewcomer snewcomer commented Mar 3, 2020

An end user would do something like this in your codebase....

import RouterScrollService from 'ember-router-scroll/services/router-scroll';

export default class RouterScroll extends RouterScrollService {
  init() {
    super.init(...arguments);

    this.on('didScroll', () => ...)
  }
}

close #245

@snewcomer snewcomer self-assigned this Mar 3, 2020
@snewcomer snewcomer requested a review from Ravenstine March 3, 2020 23:58
Copy link

@Ravenstine Ravenstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet as!

@snewcomer snewcomer merged commit d11996a into master Mar 4, 2020
@snewcomer snewcomer deleted the sn/trigger-event branch March 4, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit event when scrollTo occurs
2 participants