Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the locationType recommendation #205

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Remove the locationType recommendation #205

merged 2 commits into from
Jul 23, 2019

Conversation

CvX
Copy link
Contributor

@CvX CvX commented Jul 23, 2019

(See #54)

Closes #174

@CvX CvX mentioned this pull request Jul 23, 2019
Closed
snewcomer
snewcomer approved these changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you.

@snewcomer snewcomer merged commit 5f8600b into DockYard:master Jul 23, 2019
@CvX CvX deleted the location-type branch June 20, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting locationType and historySupportMiddleware still needed?
2 participants
@CvX @snewcomer