Fastboot compatibility #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitely need fastboot compatibility! |
|
@arjansingh any idea why the tests are failing for 1.13? Is that all that is being waited on before merging? Would love to see this merged 😄 |
|
@rwwagner90 fixed. @bennycwong review please? |
added 2 commits
August 15, 2016 15:50
arjansingh
force-pushed
the
fastboot
branch
2 times, most recently
from
76c3a72 to
0fbe54b
Compare
|
@arjansingh looks like you need some travis.yml updates to use Chrome. You'll need this before_install: before_install:
- export CHROME_BIN=chromium-browser
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start
- npm config set spin false
- npm install -g bower
- bower --version
- npm install phantomjs-prebuilt
- phantomjs --versionYou'll also need: sudo: required
dist: trusty |
arjansingh
force-pushed
the
fastboot
branch
2 times, most recently
from
975f4bc to
055d419
Compare
`getWithDefaults` returns the value (including `null`) for any key that is defined. This caused a failure in [email protected] because you cannot do a get lookup if the lookup value is `null`.
|
@bennycwong alright we can publish this guy now |
|
Thanks @arjansingh! Let me know when the new version is published please 😄 |
|
@briangonzalez needs to be the one to publish. |
|
@rwwagner90 @bennycwong I believe this has been released on NPM as 0.0.6. At least that's what we've switched over to using since the PR is merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bennycwong