Avoid scroll on first load #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
commented
Nov 5, 2018
| @@ -55,6 +55,11 @@ export default Mixin.create({ | |||
| const url = get(this, 'currentURL'); | |||
| const hashElement = url ? document.getElementById(url.split('#').pop()) : null | |||
|
|
|||
| if (get(this, 'service.isFirstLoad')) { | |||
| get(this, 'service').unsetFirstLoad(); | |||
There was a problem hiding this comment.
So we are currently calling scrollTo on first load here - however has no effect on first load for some reason on fast pages 🤷♂️. As detailed in the referenced issue, on first load, we should not try to scroll the page when we first enter the application. On slow requests, this does show up from time to time.
So using a flag isFirstLoad, we can prevent unnecessary work.
https://github.com/dollarshaveclub/ember-router-scroll/blob/master/addon/index.js#L75
yowainwright
approved these changes
Nov 6, 2018
|
@snewcomer this looks more readable too. Would you mind adding a patch version bump? |
|
@yowainwright Patch for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #55