Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] adds git auto-tag script, nvmrc + fixes #134

Merged
merged 4 commits into from
May 8, 2018
Merged

Conversation

yowainwright
Copy link
Contributor

@yowainwright yowainwright commented May 8, 2018

Fixes future issues like #133 🎉

@yowainwright yowainwright merged commit 1efa8ee into master May 8, 2018
@yowainwright yowainwright deleted the auto-tag branch May 8, 2018 21:53
@snewcomer
Copy link
Collaborator

Nice work!

@RobbieTheWagner
Copy link
Contributor

RobbieTheWagner commented May 9, 2018

So this hook just runs after someone still manually runs npm publish right? We don't have anything automated around releasing, that I know of.

I also think we may have mistakenly bumped the version in package.json here. We don't want to release new versions for things that do not ship any changes to people. That being said, there are several commits we need to get out as a 0.7.0 release. I still do not have npm permissions, so I am unable to do it myself.

@yowainwright
Copy link
Contributor Author

@rwwagner90 read the commit messages

@yowainwright
Copy link
Contributor Author

yowainwright commented May 9, 2018

Presumptuous behavior should not lead to more repository ownership.

See the code of conduct.

@RobbieTheWagner
Copy link
Contributor

It may be helpful for you to read that code of conduct as well. I've met a ton of resistance here for silly little things, for no reason. If DSC wants to solely maintain this, without community help, I'm all for that, but you may want to not stand in the way on every single thing otherwise. Please let me know your preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants