Utilize intimate API Router#_router rather than Router#route #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is outlined in this deprecation: https://deprecations-app-prod.herokuapp.com/deprecations/v3.x/#toc_ember-routing-route-router The above deprecation is found in consuming applications that have ember-source > 3.1
RobbieTheWagner
approved these changes
Apr 11, 2018
|
I started hitting this today as well. Thanks! |
|
@rwwagner90
It looks like CI didn't pass. While I am working with you, could you ensure that CI passes? If you cannot do it, please give me the opportunity to help out. I have read your opinions and shared your opinions with my team. If you could keep in mind that the work that has been done over the last week on ember-router-scroll by me was to enable you (not hinder you) that would be appreciated. |
|
@rwwagner90 @yowainwright Looks like this is my fault. I'll work on a solution. Until then, I thing we should revert this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #118