Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README Correction - export DEFAULT class... #278

Closed
nadnoslen opened this issue Feb 5, 2021 · 2 comments
Closed

README Correction - export DEFAULT class... #278

nadnoslen opened this issue Feb 5, 2021 · 2 comments

Comments

@nadnoslen
Copy link
Contributor

nadnoslen commented Feb 5, 2021

The README's > 4.x section has a type; should read export default class ... ... the default is missing.

This can lead to strange message about not being able to find router:main at runtime.

This is the section of the README that needs correction:

Usage > 4.x

Users do not need to import and extend from ember-router-scroll anymore. In order to upgrade, you should remove this > import.

This is what your router.js should look like.

import EmberRouter from '@ember/routing/router';

export class Router extends EmberRouter {
 ...
}
@nadnoslen
Copy link
Contributor Author

See #279 for fix

@snewcomer
Copy link
Collaborator

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants