Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change timing of window.scrollTo #17

Closed
bcardarella opened this issue Aug 4, 2016 · 2 comments
Closed

Change timing of window.scrollTo #17

bcardarella opened this issue Aug 4, 2016 · 2 comments
Labels
enhancement good first issue

Comments

@bcardarella
Copy link
Member

Currently window.scrollTo is fired in didTransition which itself is wrapped in an Ember.runloop call. And the transition is fired from within the runloop. The result is that there is a jitter when scrolling to a different position. The page renders and there is a noticeable jump. It is fast but noticeable.

I believe the scroll positioning should be done elsewhere. It would be great if we could hook into an afterRender callback. Not sure if one is fired for the entire page.
@courthead courthead mentioned this issue Jul 8, 2017
Closed
cclo7 pushed a commit to cclo7/ember-router-scroll that referenced this issue Jul 15, 2017
@clo-lnkd
Schedule scrollTo work to after content paint by using ember-app-sche…
6b31541 
…duler

DockYard#17
cclo7 added a commit to cclo7/ember-router-scroll that referenced this issue Jul 15, 2017
@cclo7
Schedule scrollTo work to after content paint by using ember-app-sche…
36bbccd 
…duler

DockYard#17
@cclo7 cclo7 mentioned this issue Jul 15, 2017
Merged
briangonzalez pushed a commit that referenced this issue Aug 2, 2017
@cclo7 @briangonzalez
Schedule scrollTo work to after content paint by using ember-app-sche…
4eb771a 
…duler (#57)

#17
@snewcomer snewcomer mentioned this issue Feb 27, 2018
Closed
@snewcomer snewcomer mentioned this issue Mar 7, 2018
Merged
@joshkg
Copy link
Contributor

joshkg commented May 5, 2018

@bcardarella Should we consider this issue closed after #101?

@bcardarella
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bcardarella @joshkg @bennycwong