Run service teardown code in willDestroy()

DockYard · Mar 25, 2021 · a32f41c · a32f41c
1 parent 9d494b5
commit a32f41c
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/addon/services/router-scroll.js b/addon/services/router-scroll.js
@@ -91,9 +91,7 @@ class RouterScroll extends Service {
     addListener(this.router, 'routeDidChange', this._routeDidChange);
   }
 
-  destroy() {
-    reset();
-
+  willDestroy() {
     removeListener(this.router, 'routeWillChange', this._routeWillChange);
     removeListener(this.router, 'routeDidChange', this._routeDidChange);
 
@@ -105,7 +103,7 @@ class RouterScroll extends Service {
       window.cancelAnimationFrame(callbackRequestId);
     }
 
-    super.destroy(...arguments);
+    super.willDestroy(...arguments);
   }
 
   /**