Merge branch 'master' into pr/256

DockYard · Dec 24, 2020 · 405dab4 · 405dab4
2 parents 22a6536 + f7e5bfa
commit 405dab4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 - Updating to th v3.0 series was due to removing `scrollWhenPainted` as a config option.  Also, we fixed some hidden bugs with scheduling when to scroll to your last y position.
 
+## 3.3.5
+* [#269](https://github.com/DockYard/ember-router-scroll/pull/269) [Enhancement]: improve idle case with improved scrollTo under high loads
+
+## 3.3.4
+* [#266](https://github.com/DockYard/ember-router-scroll/pull/266) [Deps]: bump app-scheduler 5.1.1
+
 ## 3.3.0
 * [#246](https://github.com/DockYard/ember-router-scroll/pull/246) Add Evented trigger didScroll
 

diff --git a/addon/index.js b/addon/index.js
@@ -54,8 +54,6 @@ const CALLBACK = function(transition) {
 class EmberRouterScroll extends EmberRouter {
   @inject('router-scroll') service;
 
-  idlePool;
-
   @computed
   get isFastBoot() {
     const fastboot = getOwner(this).lookup('service:fastboot');
@@ -97,11 +95,6 @@ class EmberRouterScroll extends EmberRouter {
    * @param {transition|transition[]} transition If before Ember 3.6, this will be an array of transitions, otherwise
    */
   updateScrollPosition(transition) {
-    if (this.idlePool) {
-      this.idlePool.destroy();
-      this.idlePool = null;
-    }
-
     const url = get(this, 'currentURL');
     const hashElement = url ? document.getElementById(url.split('#').pop()) : null;
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ember-router-scroll",
-  "version": "3.3.5",
+  "version": "3.3.6",
   "description": "Scroll to top with preserved browser history scroll position",
   "keywords": [
     "ember-addon",