Pass the intersectionObserverEntry to callbacks of {{in-vieport}} modifier #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifier
When using the {{in-viewport}} modifier, the intersectionObserverEntry property was not being
passed to the onEnter/onExit callbacks. This object is interesting because contains useful info
like the intersection ratio, which can use to discriminate what visibility threshold an element
has crossed when there's more than one set.
Supporting them would require ember-auto-update 2, which would require a major version bump
cbroeren
reviewed
Oct 13, 2021
cibernox
commented
Oct 13, 2021
| ember-beta, | ||
| ember-default-with-jquery, | ||
| ember-classic | ||
| # ember-beta, |
There was a problem hiding this comment.
I had to comment this because tests don't pass in Ember 4.0 for reasons unrelated with this PR.
Fixing it should be relatively straightforward by updating ember-auto-import, but reading the migration guide seems that doing so would make this addon only consumable by apps using ember-auto-import >=2.0, granting it a major version bump.
I wasn't sure I wanted that mixed with this very simple change.
cbroeren
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the {{in-viewport}} modifier, the intersectionObserverEntry property was not being
passed to the onEnter/onExit callbacks. This object is interesting because contains useful info
like the intersection ratio, which can use to discriminate what visibility threshold an element
has crossed when there's more than one set.