fixes #216, remove unnecessary call to startIntersectionObserver #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #216
Changes proposed in this pull request
The
in-viewport
service has astartIntersectionObserver
function which creates an instance ofobserverAdmin
. Thein-viewport
mixin has a call tostartIntersectionObserver
that does not check to see ifobserverAdmin
already exists. This resulted in the single instance ofobserverAdmin
inside the service being replaced every time a component using the mixin was created.observerAdmin
hasWeakMap
"registry"s ofelement
references that are useful to have access to when debugging issues using this addon, and the instance changing made that impossible to leverage.The mixin's call to
startIntersectionObserver
proves to be unnecessary as it is immediately called insidewatchElement
. That call IS protected so thatobserverAdmin
is only ever created once.This PR removes the mixin's call to
startIntersectionObserver
.Thanks, all!