Raf test bounding #133
Merged
Raf test bounding #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
commented
Feb 27, 2018
| @@ -107,7 +107,7 @@ export default Mixin.create({ | |||
| this.intersectionObserver = new IntersectionObserver(bind(this, this._onIntersection), options); | |||
| this.intersectionObserver.observe(element); | |||
| } else { | |||
| const height = scrollableArea ? scrollableArea.offsetHeight + scrollableArea.getBoundingClientRect().top: window.innerHeight; | |||
| const height = scrollableArea ? scrollableArea.offsetHeight + scrollableArea.getBoundingClientRect().top : window.innerHeight; | |||
There was a problem hiding this comment.
Note the test added here fails without scrollableArea.getBoundingClientRect().top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for rAF scrollable area that is offset from top of browser window.
Also added
falseto thescrollIntoViewmethods. This aligns the bottom of the element to the bottom of the visible part of the scrollable ancestor. Previously, we were aligning the top of the element with the top of the visible area (the default)