Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom and Top Margin Issues with IntersectionObserver #129

Closed
snewcomer opened this issue Feb 24, 2018 · 0 comments
Closed

Bottom and Top Margin Issues with IntersectionObserver #129

snewcomer opened this issue Feb 24, 2018 · 0 comments
Assignees

Comments

@snewcomer
Copy link
Collaborator

snewcomer commented Feb 24, 2018

Issue

RAF

Currently we use bottom to determine when we are in-viewport here. This wasn't documented but ppl used it to start fetching before reaching the sentinel element.

IntersectionObserver

bottom actually extends the "capturing frame" of your root. So in the case a user passed bottom: 500, in fact, top is actually what we need for IntersectionObserver. However, positive rootMargin does not seem to even add inset/outset margin anyways. I'll try to put together a codepen. Overflow:hidden / auto may be the culprit.

@snewcomer snewcomer self-assigned this Feb 24, 2018
@snewcomer snewcomer changed the title Bottom and Top Margin Bottom and Top Margin Issues with IntersectionObserver Feb 24, 2018
snewcomer added a commit that referenced this issue Feb 24, 2018
snewcomer added a commit that referenced this issue Feb 24, 2018
@snewcomer snewcomer mentioned this issue Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant