Skip to content

Commit

Permalink
Merge pull request #241 from bendemboski/will-destroy
Browse files Browse the repository at this point in the history
Fix test failures in Ember 3.20: Run service teardown code in willDestroy()
  • Loading branch information
snewcomer authored Jul 14, 2020
2 parents 2da2d7d + fc1fa87 commit 5750f7f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions addon/services/in-viewport.js
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,7 @@ export default class InViewport extends Service {
}
}

destroy() {
super.destroy(...arguments);
willDestroy() {
set(this, 'registry', null);
if (this.observerAdmin) {
this.observerAdmin.destroy();
Expand Down

0 comments on commit 5750f7f

Please sign in to comment.