Rename {{contains}} helper to {{includes}} #379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renamed
{{contains}}
helper to{{includes}}
as discussed in #365. A deprecation warning is added for the old name.Additional I have refactored to code:
EmberArray.contains()
ifEmberArray.includes()
is not available.EmberArray.contains()
has been removed in 2.x.EmberArray.includes()
is available in all supported version.EmberArray
if an array of needles is provided.Array.every()
(orEmberArray.every()
) instead ofArray.reduce()
to improve readability and performance.Closes #365