fix unused helper stripping #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #308.
ef4
commented
Apr 18, 2019
| treeForAddon: function(tree) { | ||
| tree = this.filterHelpers(tree, new RegExp(/^helpers\//, 'i')); | ||
| tree = new StripBadReexports(tree, [`index.js`]); | ||
| return this._super.treeForAddon.call(this, tree); |
There was a problem hiding this comment.
Life is easier if you process the tree before it has run through _super.treeForAddon. For one thing, you no longer need to worry about whether your current version of ember-cli includes the modules subdir (which is why the original RegExp was more complex). For another, we want our StripBadReexports plugin to process the import statements before they have been compiled into AMD by ember-cli-babel.
ef4
commented
Apr 18, 2019
| @@ -38,7 +43,7 @@ module.exports = { | |||
|
|
|||
| // exit early if no opts defined | |||
| if ((!whitelist || whitelist.length === 0) && (!blacklist || blacklist.length === 0)) { | |||
| return new Funnel(tree); | |||
| return tree; | |||
There was a problem hiding this comment.
new Funnel(tree) is a no-op.
2 tasks
ctjhoa
added a commit
to concordnow/ember-cli-string-helpers
that referenced
this pull request
Mar 24, 2021
This is a port of DockYard/ember-composable-helpers#316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #308.
As there is no existing test infrastructure for running builds with different build-time options, there was not a good place to put a test so I didn't make one.
The changes here fix both parts of the problem reported in #308.
index.jsfile so it stops trying to import helpers that have already been removed.