Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Ember.isEqual #236

Merged
4 commits merged into from
Nov 1, 2016
Merged

Use Ember.isEqual #236

4 commits merged into from
Nov 1, 2016

Conversation

taras
Copy link
Contributor

@taras taras commented Oct 31, 2016

This PR modifies utils/isEqual to use Ember.isEqual. Ember.isEqual only checks if the first argument implements isEqual interface, so I have to check twice: first for second argument against first, followed by first argument against second.

Closes #235

@ghost ghost merged commit 15ddc9e into DockYard:master Nov 1, 2016
@ghost
Copy link

ghost commented Nov 1, 2016

Thanks!

@taras
Copy link
Contributor Author

taras commented Nov 1, 2016

Awesome. Thank you!

@taras taras deleted the use-is-equal branch November 1, 2016 15:23
@ghost
Copy link

ghost commented Nov 1, 2016

If there are more === in the codebase I'm happy to merge PR's to have those replaced by isEqual.

@taras
Copy link
Contributor Author

taras commented Nov 1, 2016

I looked for === and !== - only changed once that made sense.

@ghost
Copy link

ghost commented Nov 1, 2016

👍

@xomaczar
Copy link
Contributor

xomaczar commented Nov 2, 2016

npm publish?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taras @xomaczar