Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compatible with Ember 2.9.0-beta.2+. #227

Merged
merged 2 commits into from
Sep 17, 2016
Merged

Make compatible with Ember 2.9.0-beta.2+. #227

merged 2 commits into from
Sep 17, 2016

Conversation

rwjblue
Copy link
Contributor

@rwjblue rwjblue commented Sep 17, 2016

  • Avoid mutating params/hash in helpers.
  • Prevent errors when ACTION isn't needed.

Robert Jackson added 2 commits September 17, 2016 19:22
Prevent errors due to ACTION symbol being removed in 2.9+.
bed2594 
There is no auto-mut wrapping (which is what this symbol prevented) so
we do not need to do anything for this to "just work" in 2.9+.
Avoid mutating params/hash arguments to helpers.
47a7fbb 
Under 2.9+ the `params` and `hash` are both frozen (via
`Object.freeze`) which allows some nice optimizations in the rendering
layer.

This updates the `array` and `sort-by` helper to avoid mutating the
provided arguments.
@poteto
Copy link
Collaborator

poteto commented Sep 17, 2016

😍 Thank you!

@poteto poteto merged commit 5c92bd5 into DockYard:master Sep 17, 2016
@rwjblue rwjblue deleted the glimmer-2-compat branch September 18, 2016 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwjblue @poteto