Fix bug where --max-results could not be set with --no-context-annota… #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions Previously this command: `twarc2 search --archive --max-results 200 --no-context-annotations banana --limit 100` Would fail with the error: ``` Error: Invalid value for '--max-results': --max-results cannot be greater than 100 when using context annotations. Set --no-context-annotations to remove them, or don't specify them in --tweet-fields. ``` This was occuring because _validate_max_results is called before applying --no-context-annotations, this change just checks no_context_annotations as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tions
Previously this command:
twarc2 search --archive --max-results 200 --no-context-annotations banana --limit 100Would fail with the error:
This was occuring because _validate_max_results is called before
applying --no-context-annotations, this change just checks
no_context_annotations as well.