Skip to content

Commit

Permalink
[TASK] Fix make scheduler cmd for TYPO3 >6.2 (webdevops#162)
Browse files Browse the repository at this point in the history
- Determine path to typo3/cli_dispatch.phpsh by looking up
  WEB_DOCUMENT_ROOT env variable which is defined in
  etc/environment.yml and automatically available in
  the app container.
  This makes the 'make scheduler' command work for all
  TYPO3 versions.
- Run container as application user to avoid permission problems.
- Use docker-compose exec instead of docker exec,
  which speeds up the command call, because there is no
  need to determine the container id of the app container
  anymore.

Fixes webdevops#139
  • Loading branch information
tbal authored and mblaschke committed Aug 28, 2017
1 parent 123dfa6 commit d9321bb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ cli:
docker-compose run --rm --user application app cli $(ARGS)

scheduler:
docker exec -it $$(docker-compose ps -q app) typo3/cli_dispatch.phpsh scheduler $(ARGS)
# TODO: remove the workaround "; (exit $?)" when https://github.com/docker/compose/issues/3379 has been fixed
docker-compose exec --user application app /bin/bash -c '"$$WEB_DOCUMENT_ROOT"typo3/cli_dispatch.phpsh scheduler $(ARGS); (exit $$?)'

#############################
# Argument fix workaround
Expand Down

0 comments on commit d9321bb

Please sign in to comment.